Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trips Page Timezone Issue #119

Merged
merged 9 commits into from
Aug 5, 2020
Merged

Fix Trips Page Timezone Issue #119

merged 9 commits into from
Aug 5, 2020

Conversation

zghera
Copy link
Collaborator

@zghera zghera commented Jul 30, 2020

What is a quick description of the change?

Fix #89 by ensuring that all JS Date objects use UTC.

This ensures that no matter where the user is located when updating or viewing the trips, the start and end date of the trips will remain the same from the last update.

Is this fixing an issue?

Fixes #89: see above.

Are there more details that are relevant?

Moves getDateRangeString into time.js.

Check lists (check x in [ ] of list items)

  • Test written/updating
  • Tests passing
  • Coding style (indentation, etc)

Any additional comments?

@zghera zghera requested review from anan-ya-y and keiffer01 July 30, 2020 03:06
@zghera zghera self-assigned this Jul 30, 2020
@zghera zghera changed the base branch from master to integrate-auth-utils July 30, 2020 16:41
@zghera zghera marked this pull request as ready for review August 3, 2020 21:21
Base automatically changed from integrate-auth-utils to master August 5, 2020 01:55
@zghera zghera merged commit 2764c83 into master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Timezones Issue for Trip Dates
4 participants