Just use epoll for qcmp #1012
Merged
Just use epoll for qcmp #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
requested review from
markmandel,
XAMPPRocky and
koslib
as code owners
|
FWIW this is not necessarily an attempt to fix the issue we saw with QCMP as I never once found a test failure either automatic or manually with the io-uring code, but this at least removes all the complexity to make any issue easier to track down. |
|
Build Succeeded 🥳 Build Id: ad02fafd-eb07-4ae9-ac6c-fb687b90b27c The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just uses the simple epoll QCMP loop for linux, io_uring gives no benefits as we are only ever doing a single recv or send request at a time. For now it just spawns a task on the main tokio runtime, so in high CPU usage scenarios this will affect the timing, but...that might be a good thing? Unsure.