Implement suggestions from @nitobuendia 's review on #33

googlecodelabs · Sep 30, 2018 · e2536f1 · e2536f1
1 parent 130732d
commit e2536f1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/step-05/js/main.js b/step-05/js/main.js
@@ -79,8 +79,9 @@ socket.on('message', function(message) {
     pc.setRemoteDescription(new RTCSessionDescription(message));
   } else if (message.type === 'candidate' && isStarted) {
     var candidate = new RTCIceCandidate({
+      candidate: message.candidate,
+      sdpMid: message.id,
       sdpMLineIndex: message.label,
-      candidate: message.candidate
     });
     pc.addIceCandidate(candidate);
   } else if (message === 'bye' && isStarted) {

diff --git a/step-06/js/main.js b/step-06/js/main.js
@@ -160,10 +160,10 @@ function signalingMessageCallback(message) {
 
   } else if (message.type === 'candidate') {
     peerConn.addIceCandidate(new RTCIceCandidate({
-      sdpMLineIndex: message.label,
+      candidate: message.candidate,
       sdpMid: message.id,
-      candidate: message.candidate
-    }));// Firefox compatible
+      sdpMLineIndex: message.label,
+    }));
 
   } else if (message === 'bye') {
 // TODO: cleanup RTC connection?