This repository has been archived by the owner on Jun 16, 2019. It is now read-only.
fix .setMap(null) #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix MarkerClusterer.setMap(null) - issue googlearchive#47 1. added MarkerClusterer.onRemove() 2. added MarkerClusterer.listeners to keep track of listeners on map 3. moved listeners (de)registration into MarkerClusterer.setReady_() 4. extend MarkerClusterer.setReady_() to cover following action on .setMap(null) call a. clear clutters[] b. set all markers with null map c. remove event listeners on previous map
|
I pulled this but got Google Map errors when I used it in place of the original. |
|
I applied the fixes directly to the original and it works. Not sure where I went wrong with extracting the source from the package. :-( |
|
Can this be merged please? |
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix MarkerClusterer.setMap(null) - issue #47
a. clear clutters[]
b. set all markers with null map
c. remove event listeners on previous map