fix(owl-bot): OwlBot to report a skip in pull request checks #5643
+31
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwlBot postprocessor has stopped running the script since googleapis#5587. Many repositories mark the postprocessor check as required. This change reports the check status as success with a message that indicates the execution was skipped.
|
"packages-owl-bot-test (repo-automation-bots) Failing after 1s — Summary" says:
|
|
All checks have passed |
chingor13
requested changes
Jan 3, 2025
suztomo
commented
Jan 3, 2025
| @@ -615,14 +615,6 @@ const runPostProcessor = async ( | |||
| logger: GCFLogger, | |||
| breakLoop = true | |||
| ) => { | |||
| // If the pull request is from a fork and not from allowlist, skip. | |||
There was a problem hiding this comment.
Moving this logic after the declaration of createCheck.
suztomo
commented
Jan 3, 2025
| text: 'Ignored by Owl Bot because the pull request was created from a fork. See go/owlbot-skip-forks.', | ||
| summary: | ||
| 'Ignored by Owl Bot because the pull request was created from a fork', | ||
| conclusion: 'skipped', |
meltsufin
approved these changes
Jan 6, 2025
chingor13
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/385183332. After #5587 and before this change, the post processor checks were silently skipped and those repositories that mark it as required cannot merge pull requests from external contributors.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕