chore: librarian generate pull request: 20260325T205208Z#1784
chore: librarian generate pull request: 20260325T205208Z#1784
Conversation
product-auto-label
bot
added
size: xl
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, generated by the Librarian CLI, primarily focuses on enhancing the Google Cloud Storage client library. It introduces a new field for managing source objects during compose operations, refines documentation for several key API methods, and significantly upgrades the testing framework by adding new conformance test sessions and updating Python version requirements and dependencies. These changes aim to improve the library's functionality, clarity, and maintainability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various project configurations, dependencies, and test setups. Key changes include updating codeowner teams, temporarily excluding a client file from generation, and refactoring Nox sessions for testing, particularly for conformance and bidi tests. Python version requirements have been updated to >=3.10, and new grpc and testing extras have been added to setup.py. Docstrings for bidi_read_object and ReadRange have been clarified, and a new delete_source_objects field was added to ComposeObjectRequest. Additionally, mTLS-related tests were simplified. The review comments suggest improving the efficiency of bidi test execution by invoking pytest once for multiple files and removing a duplicate dependency entry for google-cloud-testutils in setup.py.
| for test_file in bidi_tests: | ||
| session.run( | ||
| "pytest", | ||
| "-vv", | ||
| "-s", | ||
| test_file, | ||
| env={"DOCKER_API_VERSION": "1.39"}, | ||
| ) |
There was a problem hiding this comment.
Instead of looping and calling pytest for each test file, it's more efficient to invoke pytest once with all test files. This avoids the overhead of starting a new process for each file.
session.run(
"pytest",
"-vv",
"-s",
*bidi_tests,
env={"DOCKER_API_VERSION": "1.39"},
)| "testing": [ | ||
| "google-cloud-testutils", | ||
| "numpy", | ||
| "psutil", | ||
| "py-cpuinfo", | ||
| "pytest-benchmark", | ||
| "PyYAML", | ||
| "mock", | ||
| "pytest", | ||
| "pytest-cov", | ||
| "pytest-asyncio", | ||
| "pytest-rerunfailures", | ||
| "pytest-xdist", | ||
| "google-cloud-testutils", | ||
| "google-cloud-iam", | ||
| "google-cloud-pubsub", | ||
| "google-cloud-kms", | ||
| "brotli", | ||
| "coverage", | ||
| "pyopenssl", | ||
| "opentelemetry-sdk", | ||
| "flake8", | ||
| "black", | ||
| ], |
There was a problem hiding this comment.
The dependency google-cloud-testutils is listed twice in the testing extras (on line 63 and 75). Please remove the duplicate entry.
"testing": [
"google-cloud-testutils",
"numpy",
"psutil",
"py-cpuinfo",
"pytest-benchmark",
"PyYAML",
"mock",
"pytest",
"pytest-cov",
"pytest-asyncio",
"pytest-rerunfailures",
"pytest-xdist",
"google-cloud-iam",
"google-cloud-pubsub",
"google-cloud-kms",
"brotli",
"coverage",
"pyopenssl",
"opentelemetry-sdk",
"flake8",
"black",
],2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Added a new field
ComposeObjectRequest.delete_source_objectsfieldPiperOrigin-RevId: 863087065
Library-IDs: google-cloud-storage
Source-link: googleapis/googleapis@51ff87f4
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Updated documentation for
BidiReadObject,ReadObjectRequest, andObjectContextsPiperOrigin-RevId: 863087065
Library-IDs: google-cloud-storage
Source-link: googleapis/googleapis@51ff87f4
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@5400ccce
(exclusive) and
googleapis/googleapis@51ff87f4
(inclusive).
Librarian Version: v1.0.2-0.20260309131826-42ac5c451239
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91