Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: enable OpenTelemetry as a first class dependency #1228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

odeke-em
Copy link
Contributor

@odeke-em odeke-em commented Nov 9, 2024

This change attempts to make OpenTelemetry a first class dependency used without any guards.

@odeke-em odeke-em requested review from a team as code owners November 9, 2024 01:03
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Nov 9, 2024
@odeke-em odeke-em force-pushed the trace-use-OTEL-dependencies-unrestricted branch from 7709c67 to ad4437b Compare November 9, 2024 03:42
@odeke-em
Copy link
Contributor Author

odeke-em commented Nov 9, 2024

Kindly pinging @harshachinta @sakthivelmanii @surbhigarg92 to kindly help me review and also run the bots.

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2024
This change attempts to make OpenTelemetry a first class
dependency used without any guards.
@odeke-em odeke-em force-pushed the trace-use-OTEL-dependencies-unrestricted branch from ad4437b to 5fedcb1 Compare November 10, 2024 21:40
@odeke-em
Copy link
Contributor Author

Kind ping @rahul2393 to help me run the bots.

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@odeke-em
Copy link
Contributor Author

It turns out that we are blocked from this PR being merged because OpenTelemetry is only supported for Python3.8 per https://opentelemetry.io/docs/languages/python/ and above while this package supports Python3.7 which went into end-of-life in 2018 https://www.python.org/downloads/release/python-370/

@odeke-em
Copy link
Contributor Author

odeke-em commented Dec 5, 2024

@harshachinta kindly help me place a "do not merge" label on this PR so that it'll be sealed and visible for when Python3.8 is finally the minimum version supported (which OpenTelemetry too supports as the minimum)

@harshachinta harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants