Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner_v1/trace: trace_call span attributes are hard-coded and don't follow OpenTelemetry semantic conventions; should instead use incorrect standardized OpenTelemetry attributes #1170

Open
4 tasks
odeke-em opened this issue Jul 24, 2024 · 0 comments
Open
4 tasks

spanner_v1/trace: trace_call span attributes are hard-coded and don't follow OpenTelemetry semantic conventions; should instead use incorrect standardized OpenTelemetry attributes #1170

odeke-em opened this issue Jul 24, 2024 · 0 comments
Assignees
@rahul2393
Labels
api: spanner Issues related to the googleapis/python-spanner API.

Comments

@odeke-em
Copy link
Contributor

odeke-em commented Jul 24, 2024 •
edited
Loading

If we examine the code in here

python-spanner/google/cloud/spanner_v1/_opentelemetry_tracing.py

Lines 41 to 46 in fe20d41

attributes = {
"db.type": "spanner",
"db.url": SpannerClient.DEFAULT_ENDPOINT,
"db.instance": session._database.name,
"net.host.name": SpannerClient.DEFAULT_ENDPOINT,
}

Fixes

We should import the package opentelemetry.semconv.attributes and from it we can use the following imported variables

  • "db.type" should be DB_SYSTEM aka "db.system" = "google.cloud.spanner"
  • "db.instance_name" should be DB_NAME aka "db.name"
  • "db.url" should use DB_CONNECTION_STRING aka "db.connection_string"
  • "net.host.name" should use NET_HOST_NAME

The code in question was written in 2020, long before OpenTelemetry standardized semantic conventions hence I am sending over a change pretty shortly to fix this!
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 24, 2024
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 25, 2024
@odeke-em
fix: use standardized OpenTelemetry attributes when tracing
6732963 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from the package `opentelemetry.semconv.attributes` as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.system"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

Fixes googleapis#1170
@odeke-em odeke-em mentioned this issue Jul 25, 2024
Closed
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 25, 2024
@odeke-em
fix: use standardized OpenTelemetry attributes when tracing
3e99517 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from the package `opentelemetry.semconv.attributes` as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.system"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

Fixes googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 25, 2024
@odeke-em
fix: use standardized OpenTelemetry attributes when tracing
dc7d3ae 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from the package `opentelemetry.semconv.attributes` as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

Fixes googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 25, 2024
@odeke-em
fix: use standardized OpenTelemetry attributes when tracing
a045aa5 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

Fixes googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 25, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
ddc0057 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Fixes googleapis#1170
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 25, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
13c326d 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Fixes googleapis#1170
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 25, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
4d31d9d 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Fixes googleapis#1170
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 25, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
c2801a5 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Fixes googleapis#1170
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 26, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
c41c4e5 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Fixes googleapis#1170
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 26, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
ed8f987 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Fixes googleapis#1170
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 26, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
ad15b89 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Fixes googleapis#1170
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 26, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
b43e4f1 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Fixes googleapis#1170
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 26, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
b83a4df 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Also added in an option toggled by environment variable

    ENABLE_EXTENDED_TRACING=true

which allows spans to be annotated with the SQL statement keyed by

    "db.statement"

Fixes googleapis#1170
Fixes googleapis#1171
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 26, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
13f4dbf 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Also added in an option toggled by environment variable

    ENABLE_EXTENDED_TRACING=true

which allows spans to be annotated with the SQL statement keyed by

    "db.statement"

Fixes googleapis#1170
Fixes googleapis#1171
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 29, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
7ab3add 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Also added in an option toggled by environment variable

    ENABLE_EXTENDED_TRACING=true

which allows spans to be annotated with the SQL statement keyed by

    "db.statement"

Fixes googleapis#1170
Fixes googleapis#1171
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 30, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
8454eae 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Also added in an option toggled by environment variable

    ENABLE_EXTENDED_TRACING=true

which allows spans to be annotated with the SQL statement keyed by

    "db.statement"

Fixes googleapis#1170
Fixes googleapis#1171
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Jul 31, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
9a315b9 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Also added in an option toggled by environment variable

    ENABLE_EXTENDED_TRACING=true

which allows spans to be annotated with the SQL statement keyed by

    "db.statement"

Fixes googleapis#1170
Fixes googleapis#1171
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Aug 9, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
a62ee3e 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Also added in an option toggled by environment variable

    ENABLE_EXTENDED_TRACING=true

which allows spans to be annotated with the SQL statement keyed by

    "db.statement"

Fixes googleapis#1170
Fixes googleapis#1171
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Aug 19, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
e69bccf 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Also added in an option toggled by environment variable

    ENABLE_EXTENDED_TRACING=true

which allows spans to be annotated with the SQL statement keyed by

    "db.statement"

Fixes googleapis#1170
Fixes googleapis#1171
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 10, 2024
@odeke-em
fix: use modernized and standardized OpenTelemetry when tracing
51caf4e 
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.

With this change we've made the replacement of these fields, directly
with imports from `opentelemetry.semconv.trace.SpanAttributes`, as:

* "db.type"       => DB_SYSTEM aka "db.system"
* "db.url"        => DB_CONNECTION_STRING aka "db.connection_string"
* "db.instance"   => DB_NAME aka "db.name"
* "net.host.name" => NET_HOST_NAME aka "net.host.name"

While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"

Also added in an option toggled by environment variable

    ENABLE_EXTENDED_TRACING=true

which allows spans to be annotated with the SQL statement keyed by

    "db.statement"

Fixes googleapis#1170
Fixes googleapis#1171
Fixes googleapis#1173
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 11, 2024
@odeke-em
opentelemetry-tracing: update dependencies from 2021 to 2024
364e24a 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Updates googleapis#1170
Fixes googleapis#1173
Built from PR#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 11, 2024
@odeke-em
opentelemetry-tracing: update dependencies from 2021 to 2024
149484b 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
@odeke-em odeke-em mentioned this issue Sep 11, 2024
Merged
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 11, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
c906c09 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 11, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
3389806 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 11, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
6ebbd27 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 11, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
0af9d6a 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 17, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
3ff423d 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example to produce traces as well
with gRPC-instrumentation enabled, and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 17, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
22f37e6 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example to produce traces as well
with gRPC-instrumentation enabled, and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 17, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
04db2a7 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example to produce traces as well
with gRPC-instrumentation enabled, and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 17, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
2645ab5 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example to produce traces as well
with gRPC-instrumentation enabled, and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 17, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
250f687 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example to produce traces as well
with gRPC-instrumentation enabled, and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 17, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
c5e2f30 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example to produce traces as well
with gRPC-instrumentation enabled, and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
harshachinta pushed a commit that referenced this issue Sep 18, 2024
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024 (#1199)
cb8a2b7 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example to produce traces as well
with gRPC-instrumentation enabled, and updated the docs.

Updates #1170
Fixes #1173
Built from PR #1172
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
adfad00 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
7807341 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
eade391 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
@odeke-em odeke-em mentioned this issue Sep 19, 2024
Merged
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
413cee0 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
8d6f2b7 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
4bc937e 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
0d5bf26 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
3617921 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: annotate Session+SessionPool events
f71d05c 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 20, 2024
@odeke-em
observability: annotate Session+SessionPool events
eb9dd5a 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Sep 20, 2024
@odeke-em
observability: annotate Session+SessionPool events
f59084c 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Nov 3, 2024
@odeke-em
observability: annotate Session+SessionPool events
c94ba6b 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Nov 9, 2024
@odeke-em
observability: annotate Session+SessionPool events
20565f9 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Nov 11, 2024
@odeke-em
observability: annotate Session+SessionPool events
f0ee013 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Nov 14, 2024
@odeke-em
observability: annotate Session+SessionPool events
2bd9168 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Nov 14, 2024
@odeke-em
observability: annotate Session+SessionPool events
021a64c 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Nov 15, 2024
@odeke-em
observability: annotate Session+SessionPool events
0207a8e 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Nov 18, 2024
@odeke-em
observability: annotate Session+SessionPool events
9b3c5bb 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Dec 3, 2024
@odeke-em
observability: annotate Session+SessionPool events
1a1b59c 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Dec 5, 2024
@odeke-em
observability: annotate Session+SessionPool events
350c4e1 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
odeke-em added a commit to odeke-em/python-spanner that referenced this issue Dec 6, 2024
@odeke-em
observability: annotate Session+SessionPool events
1d7e440 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates googleapis#1170
harshachinta pushed a commit that referenced this issue Dec 6, 2024
@odeke-em
observability: annotate Session+SessionPool events (#1207)
a6811af 
This change adds annotations for session and session pool
events to aid customers in debugging latency issues with
session pool malevolence and also for maintainers to
figure out which session pool type is the most appropriate.

Updates #1170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the googleapis/python-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use modernized and standardized OpenTelemetry when tracing odeke-em/python-spanner
2 participants
@odeke-em @rahul2393