Move attempts into try block

googleapis · Dec 10, 2024 · a194c3f · a194c3f
1 parent 7ed482e
commit a194c3f
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/google/cloud/spanner_v1/session.py b/google/cloud/spanner_v1/session.py
@@ -479,14 +479,17 @@ def run_in_transaction(self, func, *args, **kw):
                 else:
                     txn = self._transaction
 
-                attempts += 1
-                span_attributes = {"attempt": attempts}
-                txn_id = getattr(txn, "_transaction_id", "") or ""
-                if txn_id:
-                    span_attributes["transaction.id"] = txn_id
+                span_attributes = dict()
 
                 try:
+                    attempts += 1
+                    span_attributes["attempt"] = attempts
+                    txn_id = getattr(txn, "_transaction_id", "") or ""
+                    if txn_id:
+                        span_attributes["transaction.id"] = txn_id
+
                     return_value = func(txn, *args, **kw)
+
                 except Aborted as exc:
                     del self._transaction
                     if span: