Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mark database argument for get_by_id and its async counterpart as ignored #905

Merged
merged 3 commits into from
Aug 9, 2023
Merged

docs: Mark database argument for get_by_id and its async counterpart as ignored #905

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77591b3
docs: Mark database argument for get_by_id and its async counterpart …
rwhogg Aug 4, 2023
73891f0
Update google/cloud/ndb/model.py
rwhogg Aug 9, 2023
a12ece6
Update google/cloud/ndb/model.py
rwhogg Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/ndb/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5764,8 +5764,7 @@ def _get_by_id(
``global_cache_timeout``.
max_memcache_items (int): No longer supported.
force_writes (bool): No longer supported.
database (Optional[str]): Database for the entity to load. If not
passed, uses the client's value.
database (Optional[str]): This parameter is ignored. Please set the database on the Client instead.

Returns:
Optional[Model]: The retrieved entity, if one is found.
Expand Down Expand Up @@ -5851,6 +5850,7 @@ def _get_by_id_async(
``global_cache_timeout``.
max_memcache_items (int): No longer supported.
force_writes (bool): No longer supported.
database (Optional[str]): This parameter is ignored. Please set the database on the Client instead.

Returns:
tasklets.Future: Optional[Model]: The retrieved entity, if one is
Expand Down