fix: async client uses fixed grace period #1236
Open
+66
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a channel refresh occurs, the async client would use
channel.close()with a grace parameter to allow previous channels to keep serving old requests for a time. We were seeing flakes in our tests, showing thatchannel.close()isn't reliable, and can sometimes cancel ongoing requests before the grace period endsThis PR fixes this by using a fixed sleep time before calling close in the async client, like the sync client already does. This should remove the potential for cancelled requests before the grace period ends, and improve test flakiness
I also updated the system test to fully capture this problematic state, instead of encountering it in a random race condition