Skip to content

fix: RuntimeError: dictionary changed size during iteration #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: RuntimeError: dictionary changed size during iteration #546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3871e81
Avoid modifying _instances while iterating over it in get_rule by mut…
YLivay Oct 27, 2025
774fb89
optimistic locking
YLivay Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion proto/marshal/marshal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import abc
import enum
import threading

from google.protobuf import message
from google.protobuf import duration_pb2
Expand Down Expand Up @@ -256,6 +257,7 @@ class Marshal(BaseMarshal):
"""

_instances = {}
_instances_lock = threading.Lock()

def __new__(cls, *, name: str):
"""Create a marshal instance.
Expand All @@ -267,7 +269,13 @@ def __new__(cls, *, name: str):
"""
klass = cls._instances.get(name)
if klass is None:
klass = cls._instances[name] = super().__new__(cls)
with cls._instances_lock:
klass = cls._instances.get(name)
if klass is None:
klass = super().__new__(cls)
instances_copy = cls._instances.copy()
instances_copy[name] = klass
cls._instances = instances_copy

return klass

Expand Down
Loading