feat: Enhance authorization token validation with authRequired #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue where the system could inaccurately identify the authorization tokens still needed for tool invocation. The `identify_required_authn_params` helper has been updated to leverage its new capability of recognizing all alternatives of required authorization tokens. A new `ToolboxTool` member variable, `__required_authz_tokens`, now stores these alternatives. The tool invocation logic correctly uses this to check if any matching token has been provided. This new member variable is also updated correctly by the remaining authz tokens while adding auth token getters, and validated right before tool invocation.
anubhav756
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps determine the necessary authrz tokens for tool invocation. This is achieved by getting
authRequiredfrom the tool's schema during parsing and then leveraging new capabilities of theidentify_required_authn_paramshelper.Improvements
identify_required_authn_paramshelper's new capability to recognize required authorization tokens is now fully utilized.ToolboxToolmember variable,__required_authz_tokens, is introduced to store these remaining alternative authorization tokens derived from the schema.__required_authz_tokensto accurately check if at least one of the required tokens (as defined by theauthRequired) has been provided.__required_authz_tokensis updated when auth token getters are added throughadd_auth_token_getters.Note
The validation of whether all the given auth token getters are utilized are added in #220.