feat: Track utilized auth services #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhav756
force-pushed
the
anubhav-re-bind-error
branch
from
1488cb7 to
9c03dac
Compare
anubhav756
force-pushed
the
anubhav-used-params
branch
from
4995d2f to
8b5e777
Compare
anubhav756
force-pushed
the
anubhav-re-bind-error
branch
from
9c03dac to
f6301bd
Compare
anubhav756
force-pushed
the
anubhav-used-params
branch
from
8b5e777 to
ef02615
Compare
anubhav756
force-pushed
the
anubhav-re-bind-error
branch
from
f6301bd to
af85f09
Compare
This PR expands the `identify_required_authn_params` helper function. Previously, it only identified missing auth params based on requirements and available token getters. Now, the helper also returns a list of the auth token getters that were actually used during the identification process. > [!NOTE] > This enhancement is a preparatory step for implementing `strict` flag validation in an upcoming PR, allowing us to determine if all provided authentication methods were necessary.
anubhav756
force-pushed
the
anubhav-used-params
branch
from
ef02615 to
684f744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the
identify_required_authn_paramshelper function. Previously, it only identified missing auth params based on requirements and available token getters.Now, the helper also returns a list of the auth token getters that were actually used during the identification process.
Note
This enhancement is a preparatory step for implementing
strictflag validation in an upcoming PR, allowing us to determine if all provided auth getters were necessary.