-
Notifications
You must be signed in to change notification settings - Fork 130
chore(deps): update dependency com.google.cloud:sdk-platform-java-config to v3.55.1 #4060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine dependency update for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the com.google.cloud:sdk-platform-java-config dependency from 3.54.2 to 3.55.0. The changes correctly apply this version update across the parent POMs and the Kokoro CI configuration files. My review includes two suggestions to improve maintainability by reducing duplication in both the CI configuration and the Maven project structure. These changes would simplify future dependency updates.
| env_vars: { | ||
| key: "TRAMPOLINE_IMAGE" | ||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_a:3.54.2" | ||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_a:3.55.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version 3.55.0 is hardcoded here and in 5 other .kokoro configuration files (graalvm-native-b.cfg and graalvm-native-c.cfg in both continuous and presubmit directories). This makes version updates tedious and error-prone.
Consider defining this version in a central place and referencing it here, if the Kokoro configuration format supports variables or includes. This would significantly improve maintainability for future dependency updates.
| <parent> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>sdk-platform-java-config</artifactId> | ||
| <version>3.54.2</version> | ||
| <version>3.55.0</version> | ||
| <relativePath/> | ||
| </parent> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This <parent> declaration duplicates the one in the root pom.xml. To improve maintainability and avoid having to update the version in multiple places, this module should inherit from the project's parent POM (google-cloud-bigquery-parent). This centralizes the sdk-platform-java-config dependency version management in the root pom.xml.
After applying this suggestion, you can also remove the <version> element (line 6) from this pom.xml as it will be inherited from the new parent.
| <parent> | |
| <groupId>com.google.cloud</groupId> | |
| <artifactId>sdk-platform-java-config</artifactId> | |
| <version>3.54.2</version> | |
| <version>3.55.0</version> | |
| <relativePath/> | |
| </parent> | |
| <parent> | |
| <groupId>com.google.cloud</groupId> | |
| <artifactId>google-cloud-bigquery-parent</artifactId> | |
| <version>2.57.2-SNAPSHOT</version> | |
| <relativePath>../pom.xml</relativePath> | |
| </parent> |
c6ccf2e to
c42a3a9
Compare
|
/gcbrun |
This PR contains the following updates:
3.54.2→3.55.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.