Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Jan 13, 2026

Fixes: #3972

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jan 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the retry and timeout mechanisms within the RemoteBigQueryHelper class, primarily impacting test environments. It introduces exponential backoff for retries and significantly shortens default timeout durations to improve test efficiency and reliability, addressing a reported issue.

Highlights

  • Refactored Timeout Constant: The connectTimeout variable in RemoteBigQueryHelper.java has been renamed to CONNECT_TIMEOUT_IN_MS for improved clarity and adherence to naming conventions, and its usage updated accordingly.
  • Enabled Exponential Backoff for Retries: The retrySettings() method now configures exponential backoff with a multiplier of 1.5, which is a more robust strategy for handling transient failures in tests.
  • Optimized Test Retry Durations: Default retry and RPC timeout durations within RemoteBigQueryHelper have been significantly reduced (e.g., total timeout from 120 seconds to 3 seconds) to minimize overall test execution time, with comments explaining this optimization.
  • Updated Test Assertions: The RemoteBigQueryHelperTest has been updated to reflect the new, shorter retry and RPC timeout settings, ensuring tests correctly validate the updated configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables exponential backoff for retries in tests by updating the retrySettings in RemoteBigQueryHelper. The changes also include reducing timeout values to speed up tests and improving constant naming. The test file RemoteBigQueryHelperTest is updated accordingly.

My review includes a suggestion to improve variable naming for consistency and clarity in the retrySettings method. Overall, the changes are good and improve the test setup.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 13, 2026
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2026
@lqiu96 lqiu96 requested a review from jinseopkim0 January 13, 2026 21:56
@lqiu96 lqiu96 marked this pull request as ready for review January 13, 2026 21:56
@lqiu96 lqiu96 requested review from a team as code owners January 13, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky: ITRemoteUDFTest.testRoutineRemoteUDF fails with internal error

2 participants