fix: bump grpcio to 1.59.0; require Python 3.10+#17351
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the minimum version of grpcio and grpcio-status to 1.59.0 across multiple packages, including google-api-core, google-cloud-pubsub, google-cloud-spanner, and google-cloud-bigquery. The reviewer identified several issues where the updated dependency constraints would accidentally omit these libraries for Python versions below 3.11 (such as Python 3.10, which is still supported). Additionally, the reviewer recommended adding the ; python_version < '3.14' environment marker to prevent overlapping requirements on Python 3.14 and above.
e08a0fd to
d4112f0
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request drops support for Python 3.7, 3.8, and 3.9 across multiple packages, bumping the minimum required Python version to 3.10. It also upgrades the minimum version of grpcio and grpcio-status dependencies to 1.59.0 across several configuration and setup files, and temporarily skips some geography-related tests in sqlalchemy-bigquery. The review feedback recommends adding a < 2.0.0 upper bound constraint to grpcio-status in both the YAML post-processing configuration and google-cloud-pubsub's setup file to prevent future compatibility issues, as well as using flexible regex patterns instead of hardcoded versions in the YAML files.
hebaalazzeh
left a comment
There was a problem hiding this comment.
Looks good! This systematic cleanup of our Python version requirements and dependency constraints is a great improvement for long-term maintainability. Great job!
PR #17260 bumped grpcio to 1.59.0 in gapic-generator. We should also make this change throughout the monorepo to reduce the maintenance burden of having multiple minimum versions.
Fixes https://github.com/googleapis/google-cloud-python/security/dependabot/642
Fixes https://github.com/googleapis/google-cloud-python/security/dependabot/641
Fixes https://github.com/googleapis/google-cloud-python/security/dependabot/120
Fixes https://github.com/googleapis/google-cloud-python/security/dependabot/672
See follow up issue for failing
sqlalchemy-bigquerytests: #17287