Skip to content

fix: bump grpcio to 1.59.0; require Python 3.10+#17351

Open
parthea wants to merge 4 commits into
mainfrom
bump-grpcio
Open

fix: bump grpcio to 1.59.0; require Python 3.10+#17351
parthea wants to merge 4 commits into
mainfrom
bump-grpcio

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Jun 2, 2026

PR #17260 bumped grpcio to 1.59.0 in gapic-generator. We should also make this change throughout the monorepo to reduce the maintenance burden of having multiple minimum versions.

Fixes https://github.com/googleapis/google-cloud-python/security/dependabot/642
Fixes https://github.com/googleapis/google-cloud-python/security/dependabot/641
Fixes https://github.com/googleapis/google-cloud-python/security/dependabot/120
Fixes https://github.com/googleapis/google-cloud-python/security/dependabot/672

See follow up issue for failing sqlalchemy-bigquery tests: #17287

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum version of grpcio and grpcio-status to 1.59.0 across multiple packages, including google-api-core, google-cloud-pubsub, google-cloud-spanner, and google-cloud-bigquery. The reviewer identified several issues where the updated dependency constraints would accidentally omit these libraries for Python versions below 3.11 (such as Python 3.10, which is still supported). Additionally, the reviewer recommended adding the ; python_version < '3.14' environment marker to prevent overlapping requirements on Python 3.14 and above.

Comment thread packages/google-api-core/pyproject.toml Outdated
Comment thread packages/google-cloud-bigquery/pyproject.toml Outdated
Comment thread packages/google-cloud-bigquery/pyproject.toml Outdated
Comment thread packages/bigquery-magics/setup.py Outdated
Comment thread packages/sqlalchemy-bigquery/setup.py Outdated
Comment thread packages/google-cloud-core/setup.py
Comment thread packages/google-cloud-pubsub/setup.py
Comment thread packages/google-cloud-spanner/setup.py
@parthea parthea force-pushed the bump-grpcio branch 4 times, most recently from e08a0fd to d4112f0 Compare June 2, 2026 20:53
@parthea parthea marked this pull request as ready for review June 3, 2026 15:35
@parthea parthea requested review from a team as code owners June 3, 2026 15:35
@parthea parthea requested review from tswast and removed request for a team June 3, 2026 15:35
@parthea parthea changed the title fix: bump grpcio to 1.59.0 fix: bump grpcio to 1.59.0; require Python 3.10+ Jun 3, 2026
@parthea parthea requested a review from hebaalazzeh June 3, 2026 15:38
@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Jun 3, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request drops support for Python 3.7, 3.8, and 3.9 across multiple packages, bumping the minimum required Python version to 3.10. It also upgrades the minimum version of grpcio and grpcio-status dependencies to 1.59.0 across several configuration and setup files, and temporarily skips some geography-related tests in sqlalchemy-bigquery. The review feedback recommends adding a < 2.0.0 upper bound constraint to grpcio-status in both the YAML post-processing configuration and google-cloud-pubsub's setup file to prevent future compatibility issues, as well as using flexible regex patterns instead of hardcoded versions in the YAML files.

Comment thread .librarian/generator-input/client-post-processing/pubsub-integration.yaml Outdated
Comment thread packages/google-cloud-pubsub/setup.py Outdated
@parthea parthea requested a review from a team as a code owner June 3, 2026 15:51
Copy link
Copy Markdown
Contributor

@hebaalazzeh hebaalazzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This systematic cleanup of our Python version requirements and dependency constraints is a great improvement for long-term maintainability. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants