Skip to content

test(bigframes): Disable ibis fallback for system tests#17333

Merged
TrevorBergeron merged 4 commits into
mainfrom
tbergeron_experimental_for_Tests
Jun 2, 2026
Merged

test(bigframes): Disable ibis fallback for system tests#17333
TrevorBergeron merged 4 commits into
mainfrom
tbergeron_experimental_for_Tests

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new session-scoped, autouse pytest fixture use_sqlglot_compiler in packages/bigframes/tests/system/conftest.py. This fixture configures the SQL compiler option to "experimental" for the duration of the test session and restores the original setting afterward. There are no review comments, and I have no feedback to provide.

@TrevorBergeron TrevorBergeron requested a review from tswast June 2, 2026 17:20
@TrevorBergeron TrevorBergeron marked this pull request as ready for review June 2, 2026 17:20
@TrevorBergeron TrevorBergeron requested review from a team as code owners June 2, 2026 17:20
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TrevorBergeron TrevorBergeron enabled auto-merge (squash) June 2, 2026 20:39
@TrevorBergeron TrevorBergeron merged commit f7089cc into main Jun 2, 2026
31 of 32 checks passed
@TrevorBergeron TrevorBergeron deleted the tbergeron_experimental_for_Tests branch June 2, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants