Skip to content

tests: remove hardcoded packages in system.sh #17301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 6 commits into from
May 28, 2026
Merged

tests: remove hardcoded packages in system.sh #17301

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c903de
tests: remove hardcoded packages in system.sh
parthea May 28, 2026
7325cde
for testing purposes
parthea May 28, 2026
a510e63
Apply suggestions from code review
parthea May 28, 2026
203f511
add comment
parthea May 28, 2026
8f67dbd
add comment
parthea May 28, 2026
41c6eee
revert
parthea May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 14 additions & 28 deletions .kokoro/system.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,35 +90,9 @@ run_package_test() {
return $res
}

packages_with_system_tests=(
"bigframes"
"google-auth"
"google-cloud-bigquery-storage"
"google-cloud-bigtable"
"google-cloud-compute"
"google-cloud-compute-v1beta"
"google-cloud-datastore"
"google-cloud-dns"
"google-cloud-error-reporting"
"google-cloud-firestore"
"google-cloud-logging"
"google-cloud-ndb"
"google-cloud-pubsub"
"google-cloud-spanner"
"google-cloud-storage"
"google-cloud-testutils"
"pandas-gbq"
"sqlalchemy-bigquery"
"sqlalchemy-spanner"
)

# A file for running system tests
system_test_script="${PROJECT_ROOT}/.kokoro/system-single.sh"

# Join array elements with | for the pattern match
packages_with_system_tests_pattern=$(printf "|*%s*" "${packages_with_system_tests[@]}")
packages_with_system_tests_pattern="${packages_with_system_tests_pattern:1}" # Remove the leading pipe

# Run system tests for each package with directory packages/*/tests/system
for path in `find 'packages' \
\( -type d -wholename 'packages/*/tests/system' \) -o \
Expand All @@ -142,8 +116,20 @@ for path in `find 'packages' \
"${package_path}/**/version.py"
)

# If the package is in our "always run full system tests" list, check the whole directory
if [[ $package_name == @($packages_with_system_tests_pattern) ]]; then
# Hand-written (non-GAPIC_AUTO) packages or google-cloud-compute should check
# the whole directory for changes.
metadata="${package_path}/.repo-metadata.json"
library_type="UNKNOWN"
if [ -f "$metadata" ]; then
library_type=$(sed -n 's/.*"library_type":[[:space:]]*"\([^"]*\)".*/\1/p' "$metadata")
library_type="${library_type:-UNKNOWN}"
fi

# System tests always run in release PRs, regardless of library type.
# Automated GAPIC libraries bypass system tests in non-release PRs because their generation is deterministic.
# However, google-cloud-compute is included because its Discovery-based nature requires additional
# verification.
if [[ "${library_type}" != "GAPIC_AUTO" || "${package_name}" == "google-cloud-compute"* ]]; then
files_to_check=("${package_path}")
fi

Expand Down
Loading