Change list_secrets to use async await#16477
Draft
Lucioric2000 wants to merge 1 commit intogoogleapis:mainfrom
Draft
Change list_secrets to use async await#16477Lucioric2000 wants to merge 1 commit intogoogleapis:mainfrom
Lucioric2000 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The list_secrets call returns a coroutine that should be awaited, therefore, I am introducing the await instruction, which was absent, to the async secrets getter example.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the asynchronous sample for listing secrets in the Google Cloud Secret Manager by adding the missing await keyword to the list_secrets method call. This ensures the asynchronous request is properly executed within the async function. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list_secrets call returns a coroutine that should be awaited, therefore, I am introducing the await instruction, which was absent, to the async secrets getter example.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕