Skip to content

Change list_secrets to use async await#16477

Draft
Lucioric2000 wants to merge 1 commit intogoogleapis:mainfrom
Lucioric2000:patch-1
Draft

Change list_secrets to use async await#16477
Lucioric2000 wants to merge 1 commit intogoogleapis:mainfrom
Lucioric2000:patch-1

Conversation

@Lucioric2000
Copy link
Copy Markdown

The list_secrets call returns a coroutine that should be awaited, therefore, I am introducing the await instruction, which was absent, to the async secrets getter example.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

The list_secrets call returns a coroutine that should be awaited, therefore, I am introducing the await instruction, which was absent, to the async secrets getter example.
@Lucioric2000 Lucioric2000 requested review from a team as code owners March 30, 2026 18:09
@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 30, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Lucioric2000 Lucioric2000 marked this pull request as draft March 30, 2026 18:09
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the asynchronous sample for listing secrets in the Google Cloud Secret Manager by adding the missing await keyword to the list_secrets method call. This ensures the asynchronous request is properly executed within the async function. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant