fix: add retry behavior documentation to insertall interface to clarify the behavior - #14058
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Javadoc for the insertAll method in BigQuery.java to document retry behavior and transient error handling when insert IDs are not provided. The reviewer suggested separating this explanation into its own paragraph before the code example to improve readability.
Comment on lines
+1357
to
+1360
| * <p>Example of inserting rows into a table without running a load job. | ||
| * To prevent duplicate rows, this method does not perform automatic retries unless | ||
| * insert IDs are provided. Transient service errors (such as UNAVAILABLE) may be thrown and | ||
| * should be handled by the caller when insert IDs are not provided. |
Contributor
There was a problem hiding this comment.
The retry behavior explanation is currently placed directly inside the paragraph describing the example, interrupting the flow between the example description and the actual code block. Separating the retry behavior note into its own paragraph before the example improves readability and structure.
Suggested change
| * <p>Example of inserting rows into a table without running a load job. | |
| * To prevent duplicate rows, this method does not perform automatic retries unless | |
| * insert IDs are provided. Transient service errors (such as UNAVAILABLE) may be thrown and | |
| * should be handled by the caller when insert IDs are not provided. | |
| * <p>To prevent duplicate rows, this method does not perform automatic retries unless | |
| * insert IDs are provided. Transient service errors (such as UNAVAILABLE) may be thrown and | |
| * should be handled by the caller when insert IDs are not provided. | |
| * | |
| * <p>Example of inserting rows into a table without running a load job. |
yirutang
approved these changes
Aug 12, 2026
GaoleMeng
changed the title
GaoleMeng
enabled auto-merge (squash)
August 12, 2026 23:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.