ci(bigquery): configure us-east7 endpoint overrides in Kokoro integration tests - #13971
ci(bigquery): configure us-east7 endpoint overrides in Kokoro integration tests#13971jinseopkim0 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds region-specific environment variables for BigQuery and BigQuery Storage endpoints (BIGQUERY_ENDPOINT and BIGQUERY_STORAGE_ENDPOINT) to the Kokoro presubmit and integration configuration files. There are no review comments, and I have no feedback to provide.
52eb330 to
81baaa3
Compare
|
|
||
| @Test | ||
| void testListDatasets() { | ||
| // This test queries public datasets, which are not supported by regional endpoints. |
There was a problem hiding this comment.
IIUC, these tests won't run at all in the CIs? I don't think there is a way to dynamically switch between the two or have two jobs.
For the tests that touch the public dataset, would it be better to have two BQ clients?
e.g.
us-east-7 for stuff that creates new datasets/ table
normal endpoint to stuff that touches public datasets?
Maybe a long term fix to align everything would be to rewrite the public dataset tests to create local datasets so we don't need a split of endpoints?
There was a problem hiding this comment.
Thanks for catching that. I've updated the code so that we have two BQ clients as suggested.
80f7b86 to
9773809
Compare
f48f600 to
472ebb0
Compare
… tests Configures the 'BIGQUERY_ENDPOINT' and 'BIGQUERY_STORAGE_ENDPOINT' environment variables in the Kokoro presubmit and GraalVM test configuration files to point to the 'us-east7' regional endpoints. Additionally, un-skips the integration tests when running against regional endpoints by instantiating separate global client instances inside the tests for the cases that query public datasets (which are only available globally).
472ebb0 to
e8d74fd
Compare
2 participants
Configures
BIGQUERY_ENDPOINTandBIGQUERY_STORAGE_ENDPOINTenvironment variables in Kokoro presubmit configs to test againstus-east7regional endpoints.Key Changes
us-east7endpoint overrides to BigQuery integration and GraalVM presubmit configurations.globalBigQuery,globalReadClient,globalWriteClient) for tests querying public datasets (bigquery-public-data) or cross-region resources, while standard clients targetus-east7.b/472499857