Conversation
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive version bump across the repository, advancing the main version to 1.85.0 and updating numerous module versions and dependencies, including a bump of the Java code generator to 2.71.0. Feedback identifies several incorrect version update tags in the accesscontextmanager module's POM files, which could interfere with automated release tools.
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-identity-accesscontextmanager-parent</artifactId> | ||
| <version>1.91.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | ||
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> |
There was a problem hiding this comment.
The version update tag for the parent POM is incorrect. It should use the tag corresponding to the parent artifact (google-identity-accesscontextmanager:current) instead of the one for the v1 proto. This ensures that the parent version is correctly tracked and updated by automated release tools.
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | |
| <version>1.92.0</version><!-- {x-version-update:google-identity-accesscontextmanager:current} --> |
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-identity-accesscontextmanager-parent</artifactId> | ||
| <version>1.91.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | ||
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> |
There was a problem hiding this comment.
The version update tag for the parent POM is incorrect. It should use the tag corresponding to the parent artifact (google-identity-accesscontextmanager:current) instead of the one for the v1 proto.
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | |
| <version>1.92.0</version><!-- {x-version-update:google-identity-accesscontextmanager:current} --> |
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-identity-accesscontextmanager-type</artifactId> | ||
| <version>1.91.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | ||
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> |
There was a problem hiding this comment.
The version update tag for the proto-google-identity-accesscontextmanager-type dependency is incorrect. It should use the tag specific to that artifact (proto-google-identity-accesscontextmanager-type:current) to ensure correct automated updates.
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | |
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-type:current} --> |
🤖 I have created a release beep boop
1.85.0
1.85.0 (2026-04-13)
Features
Enginefield to support LightningEngine in (fc62b1e)base64_encoded_nameis (fc62b1e)Bug Fixes
Documentation
regionfield in (fc62b1e)namein (fc62b1e)This PR was generated with Release Please. See documentation.