Skip to content

fix(bqjdbc): Revert DatabaseMetaData field to be non-static in BigQueryConnection#12778

Merged
Neenu1995 merged 2 commits intomainfrom
ns/dbmetadata-fix2
Apr 14, 2026
Merged

fix(bqjdbc): Revert DatabaseMetaData field to be non-static in BigQueryConnection#12778
Neenu1995 merged 2 commits intomainfrom
ns/dbmetadata-fix2

Conversation

@Neenu1995
Copy link
Copy Markdown
Contributor

No description provided.

@Neenu1995 Neenu1995 requested review from a team as code owners April 13, 2026 20:59
Copy link
Copy Markdown
Contributor

@logachev logachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also revert dynamic Statement within Metadata?

Not sure what the right call is, but might be easier to track telemetry around metadata calls if statement is being reused in a future?

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the databaseMetaData field in BigQueryConnection.java by removing the static and private modifiers. The review feedback suggests retaining the private access modifier to ensure proper encapsulation while supporting the removal of the static keyword for JDBC compliance.

@Neenu1995
Copy link
Copy Markdown
Contributor Author

Neenu1995 commented Apr 13, 2026

Should we also revert dynamic Statement within Metadata?

Not sure what the right call is, but might be easier to track telemetry around metadata calls if statement is being reused in a future?

I feel like the current pattern is better in terms of thread safety(each call uses an isolated instance, no collision) and resource management(can be closed easily with closeOnCompletion). Also, considering metadata fetching is not a very frequent operation should be ok to have a per method statement instance.

@Neenu1995 Neenu1995 added automerge Merge the pull request once unit tests and other checks pass. labels Apr 14, 2026
@Neenu1995 Neenu1995 merged commit ac69c8d into main Apr 14, 2026
110 of 115 checks passed
@Neenu1995 Neenu1995 deleted the ns/dbmetadata-fix2 branch April 14, 2026 14:12
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants