feat(storage): add internal payload timestamp plumbing for range reads - #16345
Open
kalragauri wants to merge 2 commits into
Open
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces telemetry timestamps (t4_, t5_, t6_) under conditional compilation to track latency in the asynchronous read path. The review feedback correctly highlights a severe ABI stability risk caused by adding these conditionally-compiled member variables directly to the public ReadPayload class. The reviewer recommends moving these fields into the internal implementation class (impl_) to preserve ABI stability across different build configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces internal timestamping logic to calculate latency components for Bidi-read ranges (AsyncReaderConnection::Read()). This PR acts as foundational plumbing. A follow-up PR will utilize these internal t4-t6 timestamps in object_descriptor_reader_tracing to construct and export OpenTelemetry metric histograms and span events.