refactor(bigtable): rename metric Labels types to indicate Table schema - #16337
refactor(bigtable): rename metric Labels types to indicate Table schema#16337scotthart wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request renames ResourceLabels to TableResourceLabels and DataLabels to TableDataLabels across the Bigtable internal metrics implementation, updating the clone method signatures to accept these structures by const reference instead of by value. Two issues were identified in the review: first, changing Metric::clone from a pure virtual function to a virtual function returning nullptr reduces compile-time safety and could lead to runtime null pointer dereferences; second, ApplicationBlockingLatency::clone incorrectly attempts to std::move the const& parameters, which is a no-op and misleading.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16337 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 2227 2227
Lines 209208 209241 +33
=======================================
+ Hits 192976 193007 +31
- Misses 16232 16234 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
With the upcoming introduction of Client schema metric labels, this helps differentiate.