feat(storage): add telemetry for pre-warmed ranges in ObjectDescriptorImpl - #16323
Conversation
…nges in ObjectDescriptorImpl
There was a problem hiding this comment.
Code Review
This pull request introduces tracking and telemetry for the cache status ("HIT", "MISS", "EVICTED") of pre-warmed ranges in ObjectDescriptorImpl, recording it as an OpenTelemetry span attribute. The review feedback suggests limiting the size of the new evicted_ranges_ set to prevent unbounded memory growth, and optimizing performance by using absl::string_view instead of std::string to avoid unnecessary copies of the cache status.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16323 +/- ##
==========================================
- Coverage 92.24% 92.23% -0.01%
==========================================
Files 2227 2227
Lines 209208 209283 +75
==========================================
+ Hits 192976 193030 +54
- Misses 16232 16253 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
74d6e87 to
73a17bb
Compare
25078ba to
571c9e6
Compare
This PR adds OpenTelemetry instrumentation for multi-range pre-warming requests in the GCS async client.