Skip to content

ci: separate out storage emulator from cxx20 builds#16167

Merged
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:ci_cxx20_storage_emulator
Jun 15, 2026
Merged

ci: separate out storage emulator from cxx20 builds#16167
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:ci_cxx20_storage_emulator

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the C++20 CI/CD integration test pipeline to run Google Cloud Storage integration tests separately from other integration tests. It introduces new Cloud Build triggers and modifies the build scripts to conditionally execute tests based on the INTEGRATION_LIBRARIES environment variable. The review feedback suggests scoping variables locally within the newly added integration::ctest_storage_with_emulators function by using local -r for EMULATOR_SCRIPT and declaring ctest_args as a local array to prevent global namespace pollution.

Comment thread ci/cloudbuild/builds/lib/integration.sh Outdated
Comment thread ci/cloudbuild/builds/lib/integration.sh
@scotthart scotthart marked this pull request as ready for review June 15, 2026 20:48
@scotthart scotthart requested a review from a team as a code owner June 15, 2026 20:48
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.19%. Comparing base (4112803) to head (4a953e8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16167      +/-   ##
==========================================
- Coverage   92.21%   92.19%   -0.02%     
==========================================
  Files        2264     2265       +1     
  Lines      209092   209121      +29     
==========================================
- Hits       192811   192809       -2     
- Misses      16281    16312      +31     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart enabled auto-merge (squash) June 15, 2026 21:29
@scotthart scotthart merged commit 9e80a24 into googleapis:main Jun 15, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants