Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-135): add cascading delete force-field rule #1202

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Jul 18, 2023

Adds rule core::0135::force-field that will complain if the Standard Delete request for a resource that parents other resources does not have a bool force field to implement Cascading Delete with.

Also adds a helper for collecting the child resources of a given resource, within the same service.

Fixes #1188

@noahdietz noahdietz requested a review from a team as a code owner July 18, 2023 18:32
Copy link
Contributor

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 1 Q about the parent-child algorithm, but all else looks good!

rules/internal/utils/extension.go Show resolved Hide resolved
Copy link
Contributor

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@noahdietz noahdietz merged commit 61631e7 into googleapis:main Jul 19, 2023
6 checks passed
@noahdietz noahdietz deleted the force-field branch July 19, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-135: Must include force field if resource is a parent
2 participants