Repository navigation
Fix start_date_time/end_date_time formatting and typos across campaign examples - #575
Open
pattersonlois wants to merge 5 commits into
Open
pattersonlois wants to merge 5 commits into
pattersonlois wants to merge 5 commits into
Conversation
pattersonlois
requested review from
AnashOommen and
Raibaz
and removed request for
a team
November 15, 2026 21:24
dorasun
reviewed
Nov 16, 2026
Contributor
Author
|
Following up on @dorasun's note: expanded this PR in fca11d4 to apply the same
|
Contributor
Author
|
Two quick notes for review:
|
dorasun
approved these changes
Nov 16, 2026
Raibaz
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
end_date_timetime component to23:59:59instead of00:00:00(required for daily granularity) and use ISO%Y-%m-%ddate formatting forstart_date_timeandend_date_timeacross campaign creation examples (add_campaigns.rb,add_app_campaign.rb,add_performance_max_campaign.rb,add_performance_max_retail_campaign.rb,add_demand_gen_campaign.rb,add_dynamic_search_ads.rb, andadd_responsive_search_ad_full.rb).AdImageAssetblock variable typo inadd_app_campaign.rb(aia.asset =instead ofala =), commentedcampaignblock variable inadd_responsive_search_ad_full.rb, and missingrequire 'date'inadd_dynamic_search_ads.rb.File.basename(__FILE__)in CLI usage banners across the updated campaign examples.