Repository navigation
Conversation
Change-Id: I57fa8a776fb8a1cbd43f6c1d3a1a71c3c63bdd19
Raibaz
previously approved these changes
Jul 16, 2026
Change-Id: I2f4db5b40ddc0494f631b62d60b6992f786cbf57
Raibaz
previously approved these changes
Jul 17, 2026
Contributor
Code Vetting & Review RecommendationsOverall, the implementation for adding incentive examples ( 1.
|
bobhancockg
requested changes
Jul 20, 2026
Change-Id: I19de34550a54efaa8095b503bd5e8c449930e9d4
bobhancockg
reviewed
Aug 12, 2026
Change-Id: I4f3b19fe5ace2a6d88f7f0c3b90906f97b0d454b
bobhancockg
reviewed
Aug 25, 2026
bobhancockg
left a comment
Contributor
There was a problem hiding this comment.
Overall, the implementation for adding incentive examples is well-structured and incorporates previous feedback nicely. Here are a few remaining recommendations and optimizations before merging:
-
examples/incentives/apply_incentive.rb:- Clean up redundant
request_args[:country_code] = country_code if country_codeduplicate assignment on line 36.
- Clean up redundant
-
examples/incentives/fetch_incentive.rb:- Update request field name from
type: :ACQUISITIONtoincentive_type: :ACQUISITIONto match current Google Ads API protobuf definitions (v24+) and avoid runtimeArgumentError. - Provide default
nilarguments indef fetch_incentive(email, language_code = nil, country_code = nil)and construct request args using.compact. - Fix missing whitespace in string continuation on lines 51-52 (
"type." \ "Non-CYO"->"type.Non-CYO"). - Defensively format monetary currency strings against empty protobuf defaults (
"").
- Update request field name from
Change-Id: I6dfd7bc56bafdf1910e5e35209600f3bc52a6e84
…traversal, and CLI validation
Contributor
|
Updated the PR with the following optimizations:
|
Raibaz
self-requested a review
October 7, 2026 15:44
Raibaz
previously approved these changes
Oct 7, 2026
bobhancockg
requested changes
Oct 8, 2026
- Add shebang and Encoding header - Remove trailing whitespace after .compact - Surface consolidated terms and conditions URL when present in fetch_incentive - Validate against empty email string in CLI options - Add fallback confirmation message when incentive applied without coupon code or creation time Change-Id: I5a0ed0cd2a2ef3744b28c6f83a47a12dfd2cb24d
bobhancockg
reviewed
Oct 14, 2026
…ssions, NO_INCENTIVE handling, and validation Change-Id: I3fc292a3b6a8f3180c12ede0f1e7982e32179b38
…dsError handling, use BigDecimal, and align style Change-Id: I62576463f0afe28e656ac88d82587a7fd19c1828
bobhancockg
approved these changes
Nov 19, 2026
Raibaz
approved these changes
Nov 19, 2026
Change-Id: I5ac1ed61cbc261a7622c4541d615feb6914e146a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I57fa8a776fb8a1cbd43f6c1d3a1a71c3c63bdd19