-
Notifications
You must be signed in to change notification settings - Fork 539
Asset optimization experiment updates #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
laurachevalier4
wants to merge
10
commits into
main
Choose a base branch
from
laura/asset-optimization-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fd987ae
Update experiments examples for clarity and accuracy.
laurachevalier4 fdbcb90
Additional comment updates
laurachevalier4 96690af
Merge main into this branch.
laurachevalier4 068df37
Update graduation-related comments and print statements.
laurachevalier4 c1af3a4
Update casing.
laurachevalier4 a289f5a
Address comments
laurachevalier4 3e84930
Reorder the operations in the asset optimization experiment example
laurachevalier4 cc44a8f
Merge branch 'main' of https://github.com/googleads/google-ads-python…
laurachevalier4 417249c
Refactor asset operation creation to use helper function
laurachevalier4 ac1a28e
Merge branch 'main' into laura/asset-optimization-update
bobhancockg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion (Type Hinting): Tighten the return type annotation from Tuple[Any, Any] to Tuple[MutateOperation, Any] for improved type checking and IDE autocompletion.
def _create_base_asset_operation(
client: GoogleAdsClient, customer_id: str, temp_id: str
) -> Tuple[MutateOperation, Any]: