fix: throw clear error when cwd directory does not exist#1392
Open
poetryofcode wants to merge 1 commit intogoogle:mainfrom
Open
fix: throw clear error when cwd directory does not exist#1392poetryofcode wants to merge 1 commit intogoogle:mainfrom
poetryofcode wants to merge 1 commit intogoogle:mainfrom
Conversation
When using a non-existent cwd directory, zx now throws a descriptive error message instead of failing with a cryptic spawn error. This makes debugging easier by immediately telling users what's wrong. Fixes google#1386 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
antongolub
requested changes
Feb 3, 2026
| throw new Fail(`No quote function is defined: ${Fail.DOCS_URL}/quotes`) | ||
| if ($.pieces.some((p) => p == null)) | ||
| throw new Fail(`Malformed command at ${$.from}`) | ||
| if ($.cwd) { |
Collaborator
There was a problem hiding this comment.
This could also be a link.
Collaborator
Reasonable. Conceptually agreed upon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: throw clear error when cwd directory does not exist
Summary
cwdoption before executing commandsFailerror if the directory doesn't exist or isn't adirectory
spawn errors
Before: Users got cryptic errors like "Top-level await promise never
resolved"
After: Users get clear messages like
The cwd directory does not exist: /path/to/dirTest plan
Fixes #1386