fix(build): remove incorrect await from readFileSync calls#1379
Open
Ayoub-Mabrouk wants to merge 1 commit intogoogle:mainfrom
Open
fix(build): remove incorrect await from readFileSync calls#1379Ayoub-Mabrouk wants to merge 1 commit intogoogle:mainfrom
Ayoub-Mabrouk wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Hello @antonmedv 👋 |
Ayoub-Mabrouk
force-pushed
the
fix/remove-incorrect-await-readfilesync
branch
2 times, most recently
from
0730bed to
0831e86
Compare
Remove incorrect await keyword from fs.readFileSync() calls in build-versions.mjs and build-tests.mjs. readFileSync is synchronous and doesn't return a Promise, so await is invalid syntax.
Ayoub-Mabrouk
force-pushed
the
fix/remove-incorrect-await-readfilesync
branch
from
0831e86 to
8bd0bff
Compare
Collaborator
|
PTAL @antongolub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove incorrect await keyword from fs.readFileSync() calls in build-versions.mjs and build-tests.mjs. readFileSync is synchronous and doesn't return a Promise, so await is invalid syntax.