Skip to content

Support x86 AVX-12 SIMD types on 1.89.0 stable #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Jun 9, 2025

Previously, these types were gated by the stdarch_x86_avx512 nightly
Rust feature. As of 1.89.0, they are supported on stable.


This PR is on branch simd-x86-avx12.

Previously, these types were gated by the `stdarch_x86_avx512` nightly
Rust feature. As of 1.89.0, they are supported on stable.

gherrit-pr-id: I6907ba8f144bd90d917b85c9687443fc7cf19de2
@joshlf joshlf requested a review from jswrenn June 9, 2025 15:36
@joshlf joshlf enabled auto-merge June 9, 2025 15:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (570601f) to head (85b7d31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2574   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files          20       20           
  Lines        5312     5312           
=======================================
  Hits         4720     4720           
  Misses        592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jswrenn
Copy link
Collaborator

jswrenn commented Jun 10, 2025

I think we should punt on this until 1.89 is released, and in the meantime -A stable_features in our nightly CI runs. That will allow us to get the nightly CI roller working again.

@joshlf joshlf added the blocked-on-rust Blocked on a Rust feature landing or stabilizing label Jun 10, 2025
@joshlf
Copy link
Member Author

joshlf commented Jun 10, 2025

Blocked on #2583.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-on-rust Blocked on a Rust feature landing or stabilizing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants