Add support for setting system language of newly created simulator #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `--simulator_language` argument that accepts a two-letter language code, which will be used to set the simulator's system language at startup time. Simulator language can be specified by passing `["--simulator_language", "<language-code>"]` to `ios_unit_test`/`ios_ui_test`'s [`args`](https://bazel.build/reference/be/common-definitions#common-attributes-tests) attribute. Note that because this needs to kill all booted simulators' SpringBoard to reload the new language setting, avoid setting this if you run tests on multiple simulators simultanously. Based on https://gist.github.com/koke/e3106e4531e40d2ba423b76ad789caff.
thii
force-pushed
the
add-support-for-setting-system-language-of-newly-created-simulator
branch
from
d95ee2e to
70ddcfe
Compare
|
@albertdai Can you take a look? |
|
@albertdai Can you take a look? This is a purely additive change, so should be safe to add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
--simulator_languageargument that accepts atwo-letter language code, which will be used to set the simulator's
system language at startup time. Simulator language can be specified by
passing
["--simulator_language", "<language-code>"]toios_unit_test/ios_ui_test'sargsattribute.
Note that because this needs to kill all booted simulator's SpringBoard
to reload the new language setting, avoid setting this if you run
tests on multiple simulators simultanously.
Based on https://gist.github.com/koke/e3106e4531e40d2ba423b76ad789caff.