register jsonnetfmt using buildifier as a template #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
suggested changes
Dec 2, 2022
Contributor
dbarnett
left a comment
dbarnett
left a comment
There was a problem hiding this comment.
Two questions, looks good to me otherwise.
dbarnett
added a commit
that referenced
this pull request
Dec 3, 2022
|
Hmm the jsonnetfmt (both C++ version and Go version) does not have a |
Contributor
|
Yeah, probably copypasta from some other formatter file? That means the formatter always fails if you try to format a buffer with an associated filename? Easy enough to remove if so. |
Contributor
|
I filed #231 for that and have a fix I'm about to submit for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156