Merged
Conversation
This change adds simple perf integration test in addition to existing perfetto integration tests. Signed-off-by: Santosh Kumar Aenugu <asksantu@google.com>
jahdiel-alvarez
changed the title
samueldjohnson
requested changes
Mar 13, 2026
This change re-uses the existing path resolved for fetching the symbols to be used for simpleperf. Signed-off-by: Santosh Kumar Aenugu <asksantu@google.com>
samueldjohnson
requested changes
Mar 13, 2026
This change removes newly added symbols fetching logic and relis on existing logic to locate and use symbols. Signed-off-by: Santosh Kumar Aenugu <asksantu@google.com>
This change removes default input handling logic added to handle automated test scenarios. Signed-off-by: Santosh Kumar Aenugu <asksantu@google.com>
Signed-off-by: Santosh Kumar Aenugu <asksantu@google.com>
samueldjohnson
previously requested changes
Mar 13, 2026
This change fixes the symbols handling logic. Signed-off-by: Santosh Kumar Aenugu <asksantu@google.com>
This change refactors file search logic for both perfetto and simpleperf. Signed-off-by: Santosh Kumar Aenugu <asksantu@google.com>
jahdiel-alvarez
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds simple perf integration test in addition to existing perfetto integration tests.