Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/coveragedb: fix schema in order to support multiple managers #5639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tarasmadan
Copy link
Collaborator

@tarasmadan tarasmadan commented Dec 20, 2024

Current schema makes session+filepath a primary key (it is unique).
Manager as a part of primary key makes session+filepath+manager a unique combination.
New schema allows us to store information from different managers.

Current schema makes session+filepath a primary key (it is unique).
Manager as a part of primary key makes session+filepath+manager a unique combination.
@tarasmadan
Copy link
Collaborator Author

tarasmadan commented Dec 20, 2024

Spanner doesn't support primary key changes.
Rollout will need some tables copy-paste....
P.S. What can be better than the table drop on Friday evening before vacation?!

@tarasmadan tarasmadan enabled auto-merge December 20, 2024 21:11
@tarasmadan
Copy link
Collaborator Author

It is already deployed. Please stamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant