Yocto build compatibility #5627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following standard conventions simplifies the Yocto recipe.
Currently, cross compiler names are hardcoded for each OS/arch combo. However, toolchain tuples differ, especially when using vendor provided toolchains or building with Yocto. Allow users to specify the cross compiler for an OS/arch combo using SYZ_CC_<os>_<arch> environment variables.
Depending on the cross compiler build configuration, it might not be able to emit ARMv6 Thumb-1 instructions leading to "sorry, unimplemented: Thumb-1 hard-float VFP ABI" error.
sephalon
force-pushed
the
yocto_build_compatibility
branch
from
48d2854 to
9c029f8
Compare
tarasmadan
reviewed
Dec 19, 2024
|
Regarding the syzkaller/sys/targets/targets.go Lines 940 to 953 in d7f584e It wonder why this logic did not work properly in your case. Does it only fire when a specific subset of flags is specified? |
a-nogikh
reviewed
Dec 21, 2024
| @@ -900,7 +909,7 @@ func (target *Target) lazyInit() { | |||
| // Also fail if SOURCEDIR_GOOS is set b/c in that case user probably assumes it will work. | |||
| if (target.OS != runtime.GOOS || !runningOnCI) && getSourceDir(target) == "" { | |||
| for _, comp := range []string{target.CCompiler, target.CxxCompiler} { | |||
| if _, err := exec.LookPath(comp); err != nil { | |||
| if _, err := exec.LookPath(strings.Fields(comp)[0]); err != nil { | |||
There was a problem hiding this comment.
Why is strings.Fields necessary? Can the comp contain whitespaces?
| // https://github.com/google/syzkaller/commit/06db3cec94c54e1cf720cdd5db72761514569d56 | ||
| target.Triple = "" | ||
| if OS == Linux { | ||
| if cc := os.Getenv("SYZ_CC_" + OS + "_" + arch); cc != "" { |
There was a problem hiding this comment.
I guess we can also move it out of if OS == Linux -- OS is part of the env variable name anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this line in the Yocto recipe on why we need Makefile: rename CFLAGS to CXXFLAGS and add LDFLAGS. sys/targets: allow users to override hardcoded cross-compilers and sys/targets: remove hardcoded CFlags for ARM are based upon a Yocto recipe patch. Note that there might be reasons why we need to force emitting ARMv6 code, but I could not find any hint in the history; so please let me know if we need to approach this issue in a different way.