all: show pc hit count in /rawcover and /rawcoverfiles #5617
+61
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- one pc can have multiple frames, print all frames - cache output to accelarate buf writing - output order by PC
Print the PC count when ?count=1 when accessing /rawcover*. The largest counted pc is likely overflowed, we can either disable the sanitize by KCOV_INSTRUMENT_file_name.o := n or disable by __no_sanitize_coverage for the function.
a-nogikh
reviewed
Dec 21, 2024
| sort.Slice(resFrames, func(i, j int) bool { | ||
| fl, fr := resFrames[i], resFrames[j] | ||
| if fl.PC == fr.PC { | ||
| resFrames := make(map[uint64][]backend.Frame) |
There was a problem hiding this comment.
What does this change help you achieve?
In the current code, we already print all frames. Moreover, they used to be sorted by PC, but in your change they are now shuffled by the Go's map implementation.
pkg/cover/html.go
Outdated
| if frame.Module.Name == "" { | ||
| offset = frame.PC | ||
| } | ||
| output = append(output, fmt.Sprintf("0x%x,%v,0x%x,%v,%v,%v,%v\n", |
There was a problem hiding this comment.
What is the intention switching to output []string? fmt.Fprintf directly into the buf should be the most efficient way to construct a large output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md