pkg/fuzzer/throttler: avoid repetitive crashes #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-nogikh
force-pushed
the
features/throttle-crashes
branch
6 times, most recently
from
00e187b to
b8e73f3
Compare
Track the crash rate for the individual syscalls and rate limit the execution of those which happen too often. For determining the most unsafe syscalls, let's keep a sliding window of the last executed progs on every instance. * If a program has been evicted from the sliding window, it's safe enough. * If an instance crashed, all programs in the window are under suspicion. For preventing the execution of banned syscalls, let's add a special (skip) call parameter that is understood by the executor. The parameter is not supposed to leak into the corpus, so add appropriate assertions.
a-nogikh
force-pushed
the
features/throttle-crashes
branch
from
b8e73f3 to
cbfee70
Compare
dvyukov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another attempt to address the problem.
The changes may conflict with #4905 a bit, but the changes to the conflicting files here are actually minimal possible, so we should be able to easily rebase these PRs either way.
TODO:
Track the crash rate for the individual syscalls and rate limit the execution of those which happen too often.
For determining the most unsafe syscalls, let's keep a sliding window of the last executed progs on every instance.
For preventing the execution of banned syscalls, let's add a special (skip) call parameter that is understood by the executor.
The parameter is not supposed to leak into the corpus, so add appropriate assertions.