Fix tooltip view double trigger (Follow Up). #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -190 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Build files for a4afa5d have been deleted. |
kuasha420
force-pushed
the
enhancement/7544-follow-up
branch
from
a5e4cf8 to
a4afa5d
Compare
kuasha420
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Thanks @zutigrm. The code is working, even though it feels kind of odd and the comment doesn't clearly explain it. To be fair, I am not fully sure why the whole component is remounting instead of re-rendering. Anyways, as long as it works, right?
I've based the PR off and targeted main as it's already a release ticket and the main branch was split off yesterday. Something to be mindful of in the future.
The E2E fails are unrelated.
LGTM 🎉
techanvil
reviewed
Sep 21, 2023
Comment on lines
+119
to
+120
| // appears, old component will unmount and new componnet will mount, | ||
| // with tooltip visible equal to true, so here we ensure event is sent only once when that occurs, |
There was a problem hiding this comment.
Watch out for the typos :) We should fix these, and probably try to improve the clarity of overall comment in a subsequent PR...
Suggested change
| // appears, old component will unmount and new componnet will mount, | |
| // with tooltip visible equal to true, so here we ensure event is sent only once when that occurs, | |
| // appears, old component will unmount and new component will mount, | |
| // with tooltip visible equal to true, so here we ensure event is sent only once when that occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
Addressing the comment detected in QA by @mohitwp
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist