Remove commit date from release zip #1118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a followup bug-fix to #1098
Addresses issue #1041
Relevant technical choices
This is due to the way
git-repo-info
works by parsing commit data from.git/objects/xx/...
rather than runninggit
(see When run in docker, all but sha1 is null rwjblue/git-repo-info#46). However, these objects may not exist (such as after a fresh clone) causing thecommiterDate
to benull
and thus the zip creation errors out when formatting the date (Cannot read property 'split' of null
)..git
optional, so that the release zip can still be built without itIf
.git
is present (even after a fresh clone) the file format will be:[email protected]
If
.git
is not present (i.e. zip download from GitHub) the file format will be:google-site-kit.v1.2.3.zip
Checklist