Skip to content

Enhancement/9138-dashboard-sharing-bugs #10586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 23, 2025
Merged

Enhancement/9138-dashboard-sharing-bugs #10586

merged 10 commits into from
Apr 23, 2025
+346 −4

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Apr 3, 2025 •
edited by 10upsimon
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@benbowler benbowler mentioned this pull request Mar 25, 2025
Open
2 tasks
@benbowler benbowler marked this pull request as ready for review April 11, 2025 13:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

Build files for 906bae3 have been deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

Size Change: +398 B (+0.02%)

Total Size: 2.08 MB

ℹ️ View Unchanged
Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 66 kB 0 B
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB 0 B
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B 0 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.48 kB 0 B
./dist/assets/js/33-********************.js 2.76 kB 0 B
./dist/assets/js/34-********************.js 2.25 kB 0 B
./dist/assets/js/35-********************.js 3.64 kB 0 B
./dist/assets/js/36-********************.js 935 B 0 B
./dist/assets/js/37-********************.js 892 B 0 B
./dist/assets/js/38-********************.js 1.61 kB 0 B
./dist/assets/js/39-********************.js 1.57 kB 0 B
./dist/assets/js/40-********************.js 1.61 kB 0 B
./dist/assets/js/41-********************.js 1.59 kB 0 B
./dist/assets/js/42-********************.js 1.83 kB 0 B
./dist/assets/js/43-********************.js 3.11 kB 0 B
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 492 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/index.js 7.97 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/common/editor-styles.js 491 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/contribute-with-google/index.js 9.12 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 8.62 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/subscribe-with-google/index.js 9.13 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 8.63 kB 0 B
./dist/assets/js/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
./dist/assets/js/blocks/sign-in-with-google/editor-styles.js 492 B 0 B
./dist/assets/js/blocks/sign-in-with-google/index.js 18.1 kB 0 B
./dist/assets/js/googlesitekit-activation-********************.js 24 kB 0 B
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.6 kB 0 B
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB 0 B
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB 0 B
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.45 kB 0 B
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB 0 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB 0 B
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB -2 B (-0.08%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.91 kB 0 B
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB 0 B
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB -1 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10 kB 0 B
./dist/assets/js/googlesitekit-datastore-user-********************.js 27 kB -2 B (-0.01%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81 kB +209 B (+0.26%)
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B 0 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B 0 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B 0 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B 0 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B 0 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B 0 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B 0 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B 0 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB 0 B
./dist/assets/js/googlesitekit-main-dashboard-********************.js 152 kB +184 B (+0.12%)
./dist/assets/js/googlesitekit-metric-selection-********************.js 52 kB 0 B
./dist/assets/js/googlesitekit-modules-ads-********************.js 50.5 kB 0 B
./dist/assets/js/googlesitekit-modules-adsense-********************.js 118 kB +2 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 194 kB -3 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 22.4 kB 0 B
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 26 kB 0 B
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 46.9 kB +2 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 69 kB +1 B (0%)
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 33.1 kB 0 B
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.2 kB 0 B
./dist/assets/js/googlesitekit-notifications-********************.js 47.9 kB +2 B (0%)
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B 0 B
./dist/assets/js/googlesitekit-settings-********************.js 129 kB +3 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js 69.3 kB 0 B
./dist/assets/js/googlesitekit-user-input-********************.js 44 kB -1 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 324 kB +5 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 102 kB -1 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 63.2 kB 0 B
./dist/assets/js/runtime-********************.js 1.4 kB 0 B

compressed-size-action

@10upsimon 10upsimon self-assigned this Apr 15, 2025
@10upsimon 10upsimon self-requested a review April 15, 2025 11:30
10upsimon
10upsimon approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@10upsimon 10upsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benbowler tested and all is good, and code LGTM, moving to MR ✅

eugene-manuilov

This comment was marked as resolved.

Sign in to view

@eugene-manuilov eugene-manuilov merged commit 0d12270 into develop Apr 23, 2025
19 of 22 checks passed
@eugene-manuilov eugene-manuilov deleted the enhancement/9138-dashboard-sharing-bugs branch April 23, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene-manuilov eugene-manuilov eugene-manuilov approved these changes

@10upsimon 10upsimon 10upsimon approved these changes

Assignees

@10upsimon 10upsimon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbowler @eugene-manuilov @10upsimon