Enhancement/9292 Refactor GoogleTagIDMismatchNotification

[jimmymadon]

Summary

Addresses issue:

• Refactor GoogleTagIDMismatchNotification to use the new Notifications datastore #9292

Relevant technical choices

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 7.4.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.
• Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Build files for 0ce08b4 are ready:

• Download development build
• Download production build

[github-actions]

Size Change: +693 B (+0.03%)

Total Size: 2.03 MB

Filename	Size	Change
./dist/assets/js/googlesitekit-activation-********************.js	23.8 kB	-10 B (-0.04%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js	54.3 kB	-45 B (-0.08%)
./dist/assets/js/googlesitekit-adminbar-********************.js	34.8 kB	-48 B (-0.14%)
./dist/assets/js/googlesitekit-components-gm2-********************.js	6.46 kB	+2 B (+0.03%)
./dist/assets/js/googlesitekit-components-gm3-********************.js	10.1 kB	+2 B (+0.02%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js	8.96 kB	+1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	20.5 kB	+4 B (+0.02%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js	10 kB	+1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-user-********************.js	28.4 kB	+19 B (+0.07%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js	84.8 kB	-81 B (-0.1%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js	164 kB	-967 B (-0.59%)
./dist/assets/js/googlesitekit-metric-selection-********************.js	52.2 kB	-49 B (-0.09%)
./dist/assets/js/googlesitekit-modules-********************.js	22.4 kB	-2 B (-0.01%)
./dist/assets/js/googlesitekit-modules-ads-********************.js	37.6 kB	-3 B (-0.01%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	116 kB	-53 B (-0.05%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	194 kB	+1.57 kB (+0.81%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	22.8 kB	+3 B (+0.01%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js	44.7 kB	-4 B (-0.01%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	69.6 kB	+3 B (0%)
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js	32.8 kB	-6 B (-0.02%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	32.3 kB	-2 B (-0.01%)
./dist/assets/js/googlesitekit-notifications-********************.js	43.9 kB	+194 B (+0.44%)
./dist/assets/js/googlesitekit-settings-********************.js	129 kB	+275 B (+0.21%)
./dist/assets/js/googlesitekit-splash-********************.js	69 kB	-9 B (-0.01%)
./dist/assets/js/googlesitekit-user-input-********************.js	43.9 kB	-25 B (-0.06%)
./dist/assets/js/googlesitekit-widgets-********************.js	105 kB	-15 B (-0.01%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	63.3 kB	-60 B (-0.09%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	63 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css	846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	8.48 kB
./dist/assets/js/33-********************.js	2.76 kB
./dist/assets/js/34-********************.js	2.25 kB
./dist/assets/js/35-********************.js	3.64 kB
./dist/assets/js/36-********************.js	935 B
./dist/assets/js/37-********************.js	892 B
./dist/assets/js/38-********************.js	1.61 kB
./dist/assets/js/39-********************.js	1.57 kB
./dist/assets/js/40-********************.js	1.61 kB
./dist/assets/js/41-********************.js	1.59 kB
./dist/assets/js/42-********************.js	1.83 kB
./dist/assets/js/43-********************.js	3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	901 B
./dist/assets/js/blocks/googlesitekit-reader-revenue-manager-block-editor.js	478 B
./dist/assets/js/blocks/sign-in-with-google/editor-styles.css	75 B
./dist/assets/js/blocks/sign-in-with-google/editor-styles.js	490 B
./dist/assets/js/blocks/sign-in-with-google/index.js	18 kB
./dist/assets/js/googlesitekit-api-********************.js	10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js	25.6 kB
./dist/assets/js/googlesitekit-data-********************.js	2.38 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.08 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js	646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js	624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js	630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js	712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js	675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js	634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js	657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js	633 B
./dist/assets/js/googlesitekit-i18n-********************.js	3.93 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	378 B
./dist/assets/js/googlesitekit-vendor-********************.js	325 kB
./dist/assets/js/runtime-********************.js	1.4 kB

_{compressed-size-action}

[zutigrm]

Thanks @jimmymadon looks good, just one small suggestion

Edit: oh and let's include js tests for checkRequirements like we have for all other notifications

[zutigrm]

It will be better suited to move this within assets/js/modules/analytics-4/components/notifications, like what we do for Ads notifications, since we do register it there