Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RRM CTA placement settings #10164

Merged
merged 18 commits into from
Feb 8, 2025

Conversation

nfmohit
Copy link
Collaborator

@nfmohit nfmohit commented Feb 4, 2025

Summary

Addresses issue:

Relevant technical choices

This PR updates the Reader Revenue Manager SettingsEdit screen to include the new CTA placement settings if the rrmModuleV2 feature flag is enabled.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Feb 4, 2025

Build files for 79a025d have been deleted.

Copy link

github-actions bot commented Feb 4, 2025

Size Change: +1.39 kB (+0.07%)

Total Size: 2 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 62.6 kB +99 B (+0.16%)
./dist/assets/js/36-********************.js 935 B -1 B (-0.11%)
./dist/assets/js/43-********************.js 3.11 kB -2 B (-0.06%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.1 kB -9 B (-0.02%)
./dist/assets/js/googlesitekit-adminbar-********************.js 35 kB -6 B (-0.02%)
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB -6 B (-0.06%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.46 kB +47 B (+0.73%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB +2 B (+0.02%)
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB -3 B (-0.13%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB +1 B (+0.05%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.2 kB +4 B (+0.02%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 28.2 kB +10 B (+0.04%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 82.8 kB +3 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 163 kB +16 B (+0.01%)
./dist/assets/js/googlesitekit-metric-selection-********************.js 52 kB -17 B (-0.03%)
./dist/assets/js/googlesitekit-modules-********************.js 22.4 kB -3 B (-0.01%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 36 kB +11 B (+0.03%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 119 kB +4 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 192 kB -3 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.9 kB +145 B (+0.64%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 42.3 kB +1.18 kB (+2.88%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 69.4 kB +16 B (+0.02%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.1 kB -9 B (-0.03%)
./dist/assets/js/googlesitekit-notifications-********************.js 43.3 kB -37 B (-0.09%)
./dist/assets/js/googlesitekit-settings-********************.js 128 kB +3 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js 68.7 kB +7 B (+0.01%)
./dist/assets/js/googlesitekit-user-input-********************.js 43.9 kB -7 B (-0.02%)
./dist/assets/js/googlesitekit-vendor-********************.js 325 kB -344 B (-0.11%)
./dist/assets/js/googlesitekit-widgets-********************.js 105 kB +305 B (+0.29%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 63.3 kB -12 B (-0.02%)
./dist/assets/js/runtime-********************.js 1.4 kB -3 B (-0.21%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.48 kB
./dist/assets/js/33-********************.js 2.76 kB
./dist/assets/js/34-********************.js 2.25 kB
./dist/assets/js/35-********************.js 3.64 kB
./dist/assets/js/37-********************.js 892 B
./dist/assets/js/38-********************.js 1.61 kB
./dist/assets/js/39-********************.js 1.57 kB
./dist/assets/js/40-********************.js 1.61 kB
./dist/assets/js/41-********************.js 1.59 kB
./dist/assets/js/42-********************.js 1.83 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-activation-********************.js 24.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.96 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 32.4 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B
./dist/assets/js/googlesitekit-reader-revenue-manager-block-editor-********************.js 477 B

compressed-size-action

Copy link
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @nfmohit. It almost looks good. However, can you resolve the conflicts, update the VRT images, and look at my minor comments?

@nfmohit nfmohit requested a review from hussain-t February 8, 2025 02:41
Copy link
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @nfmohit! LGTM 👍

Note: I've verified that the CI build failures are unrelated to this PR.

@hussain-t hussain-t merged commit 24f1c20 into develop Feb 8, 2025
25 of 26 checks passed
@hussain-t hussain-t deleted the enhancement/#10066-rrm-cta-placement-settings branch February 8, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants