-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RRM CTA placement settings #10164
Add RRM CTA placement settings #10164
Conversation
Build files for 79a025d have been deleted. |
Size Change: +1.39 kB (+0.07%) Total Size: 2 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @nfmohit. It almost looks good. However, can you resolve the conflicts, update the VRT images, and look at my minor comments?
assets/js/modules/reader-revenue-manager/components/settings/SettingsEdit.js
Outdated
Show resolved
Hide resolved
assets/js/modules/reader-revenue-manager/components/settings/SettingsEdit.js
Outdated
Show resolved
Hide resolved
assets/sass/components/reader-revenue-manager/_googlesitekit-rrm-settings-module.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @nfmohit! LGTM 👍
Note: I've verified that the CI build failures are unrelated to this PR.
Summary
Addresses issue:
Relevant technical choices
This PR updates the Reader Revenue Manager
SettingsEdit
screen to include the new CTA placement settings if therrmModuleV2
feature flag is enabled.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist