Skip to content

Commit

Permalink
Fix if condition in build-zips job.
Browse files Browse the repository at this point in the history
  • Loading branch information
@aaemnnosttv
aaemnnosttv committed Jan 24, 2022
1 parent 035ec1e commit 4cd7264
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .github/workflows/zips.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,15 @@ jobs:
name: Build Zips
runs-on: ubuntu-latest
timeout-minutes: 20
if: false == ( ( github.event_name == 'pull_request' && ( github.event.action == 'closed' || github.event.pull_request.draft == true || contains( github.head_ref, 'dependabot/' ) ) ) || github.event.pull_request.head.repo.fork )
if: |
false == (
github.event_name == 'pull_request' && (
github.event.action == 'closed' ||
github.event.pull_request.draft == true ||
github.event.pull_request.head.repo.fork ||
contains( github.head_ref, 'dependabot/' )
)
)
steps:
- uses: styfle/[email protected]
- uses: actions/checkout@v2
Expand Down

1 comment on commit 4cd7264

@aaemnnosttv
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expanded/formatted version of the left side is

false == (
	(
		github.event_name == 'pull_request'
		&& (
			github.event.action == 'closed'
			|| github.event.pull_request.draft == true
			|| contains( github.head_ref, 'dependabot/' )
		)
	)
	|| github.event.pull_request.head.repo.fork
)

which probably breaks for non-pull_request events because of the OR condition not equaling false 🤔

Please sign in to comment.