Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make python link conditional on an cmake variable #180

Closed
yurivict opened this issue Mar 18, 2021 · 3 comments
Closed

Please make python link conditional on an cmake variable #180

yurivict opened this issue Mar 18, 2021 · 3 comments

Comments

@yurivict
Copy link

It should be possible to turn off python bindings.

Further, python bindings should be buildable separately from the C++ library, because system can have several python versions installed at the same time, and each one can have s2geometry bindings built for it.

@spaetz
Copy link

spaetz commented Mar 23, 2021

I wanted to package s2geometry as a library for Debian, and requiring python include files even when not needing the python interface was a killer. Some inspiration to make python optional can be found here: https://github.com/rinigus/s2geometry/blob/main/CMakeLists.txt

Sorry, I don't know enough CMake magic to really provide a nice patch.

@spaetz
Copy link

spaetz commented Mar 23, 2021

Sorry, I see there is even a MR to provide this at #170

@jmr
Copy link
Member

jmr commented May 6, 2021

Fixed by #189

@jmr jmr closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants