Correct task property annotations and some other miscellaneous fixes #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with version 6.0 Gradle will show deprecation warnings for tasks with incorrect annotations. The licenses plugin has a number of these, and in this PR I'm attempting to fix them. I also made some other changes:
OssLicensesCleanupTask
as it's not required:clean
should already remove the wholebuild
directory automaticallyoutputDir
to each task as Gradle takes care of creating parent directories for@OutputFile
properties automaticallyLicensesTask
cacheable by default, and added the@PathSensitive
annotation for its input fileThere is still the question of
DependencyTask.configurations
– this is essentially consuming the whole configuration container as input. This is probably not what is intended, but I left it as is. Someone with better understanding of the intention here should capture the inputs and perhaps make the task cacheable if possible in a separate PR.There are some other things that could also be improved about the plugin in further PRs:
project.tasks.create()
useproject.tasks.register()
)RegularFileProperty
types for the task properties, so they can be connected to each other without having to manually specifydependsOn()
relationships.